Expose additional GSTheme method(s) for adding NSTabView theming to WinUXTheme #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmfrederik
referenced
this pull request
in gnustep/plugins-themes-WinUXTheme
Nov 5, 2024
* Issue 15259 - add NSTabView theming to WinUXTheme
* Remove NSLog checked in
* Issue 17388 - fix problems mixing HDC and GNUstep DPS drawing
* Fix incorrect naming
* Increase tab view item spacing
* Add error checking for hTheme - which should be correct but isn't for some reason
* Return minimum for tab height fix attempt
modified: WinNSTabView.m
* Return minimum for tab height fix attempt 2
modified: WinNSTabView.m
* Return minimum for tab height fix attempt 3
modified: WinNSTabView.m
* Return minimum for tab height fix attempt 4
modified: WinNSTabView.m
* Return minimum for tab height fix attempt final
modified: WinNSTabView.m
modified: WinUXTheme.m
* Add a maximum tab height check
modified: WinNSTabView.m
modified: WinUXTheme.m
* PR feedback
* PR feedback
---------
Co-authored-by: Marcian Lytwyn <[email protected]>
fredkiefer
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gnustep/plugins-themes-WinUXTheme#8