Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make white as default selection highlight color for NSTableView #312

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

trunkmaster
Copy link
Member

Currently default highlight color is light blue which is not correct for default theme.

Copy link
Member

@fredkiefer fredkiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the default theme we should also add an entry in the default color map we provide.

@trunkmaster
Copy link
Member Author

For the default theme we should also add an entry in the default color map we provide.

Where does that color map reside? I can't find it.

@fredkiefer
Copy link
Member

That is the problem, we only have a list of colours in the file NSColor.m. There we build up the predefined colours and store them in a new list, or add them to an already existing list. What we should do is distribute a file System.clr with colours. We have such files in themes, but not for the default theme. The reason is, that way it is easier to extend the list, whenever we need to define a new colour. This comment was rather directed at myself that I need to rectify that situation and provide a clean solution. Or perhaps I should pass on this problem to somebody who will actually resolve it?

@fredkiefer fredkiefer merged commit 42a7906 into gnustep:master Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants