modify NSComboBox to handle attributed strings #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
reviewed
Nov 4, 2024
Source/NSComboBoxCell.m
Outdated
| if (object) | ||
| { | ||
| // Check for attributed string type and return actual string instead.. | ||
| if ([object isKindOfClass :[NSAttributedString class]]) |
There was a problem hiding this comment.
Could you please move the colon to the method name, not the argument?
fredkiefer
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently NSComboBox when provided with an attributed string will display the description of an attributed string rather than the string value. The mac implementation displays the string value. This brings it into alignment with that implementation.