Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load dynamic libraries on darwin #3901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Load dynamic libraries on darwin #3901

wants to merge 2 commits into from
+19 −2

Conversation

LittleChimera
Copy link

@LittleChimera LittleChimera commented Jan 11, 2025 •
edited
Loading

Followup on #3669
Resolves #1628

@LittleChimera LittleChimera marked this pull request as ready for review January 11, 2025 14:41
@LittleChimera LittleChimera marked this pull request as draft January 11, 2025 14:41
@LittleChimera LittleChimera marked this pull request as ready for review January 11, 2025 17:01
aarzilli
aarzilli reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do TestListImages, TestPluginStepping and TestPluginVariables pass on macOS with this? The WithPlugins function that disables them wasn't changed.

@LittleChimera
Copy link
Author

LittleChimera commented Jan 12, 2025 •
edited
Loading

Do TestListImages, TestPluginStepping and TestPluginVariables pass on macOS with this? The WithPlugins function that disables them wasn't changed.

Yes, at least as far as I can tell. I'm running it on M1 Air with MacOS 15.2.

edit: however. i cannot confirm these fail on master either.

@aarzilli
Copy link
Member

Yes, at least as far as I can tell.

Did you comment out the line at pkg/proc/test/support.go:359 or exclude darwin?

@LittleChimera
Copy link
Author

Yes, at least as far as I can tell.

Did you comment out the line at pkg/proc/test/support.go:359 or exclude darwin?

thanks for the pointer. Seems like I wasn't getting the feedback the test was skipped. Looks like TestListImages fails after enabling plugin tests on darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarzilli aarzilli aarzilli left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot debug go plugins on mac
2 participants
@LittleChimera @aarzilli