refactor: ex-export the Guess type #2
Conversation
|
Friendly ping @bzz, PTAL:) |
| use crate::go::guess::{GoGuess, Guess}; | ||
| use crate::go::guess::GoGuess; | ||
|
|
||
| pub use go::guess::Guess; |
There was a problem hiding this comment.
I'm no Rust expert and am curious why re-exporting Guess is required in there, i.e. what does this mean
interfaces that rely on this type are totally unusable
? (e.g. did that result in a warning/complains by the compiler or some other tooling, etc)
There was a problem hiding this comment.
Your doubt is right, my statement is not technically correct, sorry for being inaccurate here.
The Guess type is indeed exposed and thus public, but its parent module src/go/guess.rs is not (pub(crate) mod guess, it is only visible within the crate) so those interfaces relying on it are usable, but users are not allowed to explicitly access it.
Since the Guess type is public, there are no compile errors or warnings.
However, it is still recommended to re-export the Guess type as it is used by public interfaces
There was a problem hiding this comment.
Thank you for the explanation. I'm a bit reluctant to extend public API surface without clear understand what specifically does the lack of re-export preclude the clients from.
But thinking more about it - although we don't have it in Go impl, we do seem to have Guess as part of API at e.g. Java bindings so it probably should be fine.
SteveLauC
changed the title
|
PR title and commit message updated: |
|
Is there anything else I can do to improve this PR and finally get it merged? |
What does this PR do
Guesstype defined insrc/go/guess.rsis used by many public interfaces, but this type itself has not been exported so those interfaces that rely on this type are totally unusable, this PR fixes this.