Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reviewers selection to new pull request fixes #26289 #32403

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add reviewers selection to new pull request fixes #26289 #32403

wants to merge 21 commits into from

Commits on Oct 31, 2024

  1. Add reviewers selection to new pull request form

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d37f246 View commit details
    Browse the repository at this point in the history

  2. Add translatanle clear reviewers label

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5929b87 View commit details
    Browse the repository at this point in the history

  3. Add missing continue statement

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    452828a View commit details
    Browse the repository at this point in the history

  4. Check pr creator permissions

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    906514e View commit details
    Browse the repository at this point in the history

  5. Remove unintended change

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    45b8a96 View commit details
    Browse the repository at this point in the history

  6. Check if Pull + run linter

    @splitt3r @CalK16
    splitt3r authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3e0dcea View commit details
    Browse the repository at this point in the history

  7. Fix invisible class name

    @sebastian-sauer @CalK16
    sebastian-sauer authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    978c465 View commit details
    Browse the repository at this point in the history

  8. Add request review to API

    @sebastian-sauer @CalK16
    sebastian-sauer authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c92202e View commit details
    Browse the repository at this point in the history

  9. Fix call to locale in tmpl

    @sebastian-sauer @CalK16
    sebastian-sauer authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    df3f363 View commit details
    Browse the repository at this point in the history

  10. Improve markup

    @sebastian-sauer @CalK16
    sebastian-sauer authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e4858b2 View commit details
    Browse the repository at this point in the history

  11. Fix teamreviewer ids 

    this needs to be a negative integer
    @sebastian-sauer @CalK16
    sebastian-sauer authored and CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f604ab1 View commit details
    Browse the repository at this point in the history

  12. update template to merge main

    @CalK16
    CalK16 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    60d9d96 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. move logics to proper file 

    logics for fetching reviewers in pull requests
is now placed in the RetrieveRepoMetas
    @CalK16
    CalK16 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f7c0ea4 View commit details
    Browse the repository at this point in the history

  2. postpone the review request notification 

    the review requet notifaction is now sent
after the new pull request notification.
    @CalK16
    CalK16 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    c34dd4a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @CalK16
    CalK16 authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f7f0b7a View commit details
    Browse the repository at this point in the history

  4. fix linting issues

    @CalK16
    CalK16 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0304324 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. more updates on templates 

    Some gt-* classes were replaced by the crossponding tw-* classes.
    @CalK16
    CalK16 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    800232b View commit details
    Browse the repository at this point in the history

  2. simplify a condition statement

    @CalK16
    CalK16 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    d8d66b5 View commit details
    Browse the repository at this point in the history

  3. fix an internal error 

    Team has negative ID while Users has positive.
We need to use TeamReviewRequest for teams and
ReviewRequest for a individual user.

Also, we have to validate the permissions before
send out the notification
    @CalK16
    CalK16 committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    25ebf69 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into CalK16-pr-reviewer

    @wxiaoguang
    wxiaoguang committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    418a13c View commit details
    Browse the repository at this point in the history

  5. fix conflicts

    @wxiaoguang
    wxiaoguang committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    941f7fd View commit details
    Browse the repository at this point in the history