Move AddCollabrator functions to service layer #32419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/api
lunny
force-pushed
the
lunny/refactor-collaboration
branch
from
c200c38
to
9a6b396
Compare
delvh
approved these changes
Nov 5, 2024
| @@ -8,6 +8,7 @@ import ( | |||
|
|
|||
| "code.gitea.io/gitea/models/unittest" | |||
|
|
|||
| _ "code.gitea.io/gitea/models" | |||
There was a problem hiding this comment.
I think this is a better change because that means the repository module will not depend on models directly. So that the test package needs to depend on models explicitly.
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateRepositoryByExampleto service layerAddCollabratorto service layerAddCollabratorso that changing mode immediately after that will become unnecessary.