Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the dashboard #32990

Merged
merged 22 commits into from
Feb 10, 2025
Merged

Optimize the dashboard #32990

merged 22 commits into from
Feb 10, 2025

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Dec 26, 2024

before:
image

after:
image

image

Optimize the dashboard by adding welcoming messages or quick action entry points (such as adding a new repository or organization) to ensure that new users are not greeted by a blank page upon logging in.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 26, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 26, 2024
@kerwin612 kerwin612 requested a review from lunny December 26, 2024 07:47
@kerwin612
Copy link
Member Author

image

@lunny
Copy link
Member

lunny commented Jan 2, 2025

image

Maybe remove the border of the left and put some text rather than Gitea logo

@kerwin612
Copy link
Member Author

image
Is this ok?

@kerwin612
Copy link
Member Author

image
latest screenshots

@lunny lunny added this to the 1.24.0 milestone Jan 2, 2025
@silverwind
Copy link
Member

silverwind commented Jan 13, 2025

I'd:

  • Downsize icon and title slightly
  • Make the text and icon slightly faded
  • Add a short "title" on left side too like "No Activity" and make the paragraph below with the text maybe 16px size.
  • Remove new repo/new migration buttons, they are duplicate with the + icon above.

@wxiaoguang
Copy link
Contributor

And one more thing, the "stop" icon is not suitable for this case (the users will have the question: why the icon tells me to stop here?), it needs a proper icon (if there must be an icon)

@silverwind
Copy link
Member

silverwind commented Jan 15, 2025

And one more thing, the "stop" icon is not suitable for this case (the users will have the question: why the icon tells me to stop here?), it needs a proper icon (if there must be an icon)

I agree, this icon is too close to a street sign. Kind of hard to find a suitable icon. Maybe an empty window will do:

https://www.svgrepo.com/svg/478290/empty-window

@kerwin612
Copy link
Member Author

image
latest screenshots

@kerwin612
Copy link
Member Author

Regarding the selection of appropriate icons, i can make the changes after team discussed and confirmed the options. Is that okay?

@lunny
Copy link
Member

lunny commented Jan 16, 2025

I think the right icon should also be changed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang February 10, 2025 01:13
@wxiaoguang
Copy link
Contributor

image

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 10, 2025
@lunny lunny merged commit 085f273 into go-gitea:main Feb 10, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 10, 2025
@wxiaoguang wxiaoguang deleted the add_guide_to_dashboard branch February 10, 2025 17:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 11, 2025
* giteaofficial/main:
  Enhance routers for the Actions runner operations (go-gitea#33549)
  [skip ci] Updated translations via Crowdin
  Run yamllint with strict mode, fix issue (go-gitea#33551)
  Enhance routers for the Actions variable operations (go-gitea#33547)
  enhancement: add additional command hints for PowerShell & CMD (go-gitea#33548)
  Feature: Support workflow event dispatch via API (go-gitea#33545)
  Optimize the dashboard (go-gitea#32990)
  Rework suggestion backend (go-gitea#33538)
  Revert "Feature: Support workflow event dispatch via API (go-gitea#32059)" (go-gitea#33541)
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo that referenced this pull request Feb 23, 2025
It is shown when there's no activity in the feed.

This is a partial implementation of go-gitea/gitea#32990.

Differences:
* drawer icon instead of package icon
* h2 instead of h3
* explore links include a link to organizations list
* explore links are hidden for hidden explore sections
* locales are in JSON, I think it's the time to start using it, the hint is simpler and doesn't lie about following users to get their updates in the feed, which isn't a feature yet
* hint uses general hint color instead of input placeholder color
    * the large icon still uses placeholder color, but I think it's ok

Things to improve later:
* use 24px variant of icon. This will require reworking `tools/generate-svg.js`
* the vue part wasn't ported, but it'd be also nice to have

Inspired-by: Kerwin Bryant <[email protected]>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7030
Reviewed-by: Michael Kriese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants