Skip to content

WIP: Rename/move binary files in Web UI #34350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

bytedream
Copy link
Contributor

@bytedream bytedream commented May 2, 2025

Adds the ability to rename/move binary files like binary blobs or images and files that are too large in the web ui.
This was purposed in #24722, along with the ability edit images via an upload of a new image, which I didn't implement here (could be done in a separate PR).

Binary file content:
binary

File too large:
toolarge

GitHub does the same (I've copied the text from there):
gh

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels May 2, 2025
@lunny lunny added this to the 1.25.0 milestone May 3, 2025
@lunny
Copy link
Member

lunny commented May 3, 2025

Could you also have a screenshot for editing text files stored in LFS and binary files stored in LFS?

@bytedream
Copy link
Contributor Author

bytedream commented May 3, 2025

I'm working on adding support for LFS (I thought it'd behave the same as non LFS files), and noticed that atm LFS files can be edited directly on the web ui if the file path is manually set in the URL.

(this actually is a 20MB binary file stored in LFS)
Screenshot_20250503_035508

This behavior/bug will be removed in this PR, but as it's scheduled for version 1.25, it will be present in 1.24. Should I do a separate PR that fixes this for 1.24 backporting (@lunny)?

@lunny
Copy link
Member

lunny commented May 3, 2025

I'm working on adding support for LFS (I thought it'd behave the same as non LFS files), and noticed that atm LFS files can be edited directly on the web ui if the file path is manually set in the URL.

(this actually is a 20MB binary file stored in LFS) Screenshot_20250503_035508

This behavior/bug will be removed in this PR, but as it's scheduled for version 1.25, it will be present in 1.24. Should I do a separate PR that fixes this for 1.24 backporting (@lunny)?

I think the bug fix cannot be backport easily to v1.24 if the PR is complex. But maybe we can try. Please send another PR to fix the bug.

@bytedream bytedream changed the title Rename/move binary files in Web UI WIP: Rename/move binary files in Web UI May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants