-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
WIP: Rename/move binary files in Web UI #34350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Could you also have a screenshot for editing text files stored in LFS and binary files stored in LFS? |
I'm working on adding support for LFS (I thought it'd behave the same as non LFS files), and noticed that atm LFS files can be edited directly on the web ui if the file path is manually set in the URL. (this actually is a 20MB binary file stored in LFS) This behavior/bug will be removed in this PR, but as it's scheduled for version 1.25, it will be present in 1.24. Should I do a separate PR that fixes this for 1.24 backporting (@lunny)? |
I think the bug fix cannot be backport easily to v1.24 if the PR is complex. But maybe we can try. Please send another PR to fix the bug. |
# Conflicts: # routers/web/repo/editor.go
# Conflicts: # routers/web/repo/editor.go
Adds the ability to rename/move binary files like binary blobs or images and files that are too large in the web ui.
This was purposed in #24722, along with the ability edit images via an upload of a new image, which I didn't implement here (could be done in a separate PR).
Binary file content:

File too large:

GitHub does the same (I've copied the text from there):
