Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration.md #782

Merged

Conversation

xxxVitoxxx
Copy link
Contributor

  • ONLY change English documents in the Pull Request, translations will be synced and translate them with https://translate.gorm.io/ or it will cause merge conflicts!

What did this pull request do?

description of the adjustment to the changing of an existing column. Gorm does not allow changing an existing column from non-nullable to nullable to avoid encountering an error if the original column has no value. However, the existing description can be misleading.

related issue: go-gorm/gorm#4237, go-gorm/gorm#6372

@jinzhu jinzhu merged commit eaf5012 into go-gorm:master Aug 29, 2024
@xxxVitoxxx xxxVitoxxx deleted the docs-auto-migration-change-description branch August 30, 2024 02:10
@wookie0
Copy link

wookie0 commented Nov 4, 2024

@xxxVitoxxx
I think your PR comment is wrong.

description of the adjustment to the changing of an existing column. Gorm does not allow changing an existing column from non-nullable to nullable to avoid encountering an error if the original column has no value. However, the existing description can be misleading.

I think the explanation below is correct.

Gorm does not allow changing an existing column from nullable to non-nullable to avoid encountering an error...

Is it right??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants