Generate unique savepoint names for nested transactions #7174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
approved these changes
Aug 29, 2024
demoManito
approved these changes
Sep 13, 2024
Closed
loeffel-io
reviewed
Dec 19, 2024
| // nested transaction | ||
| if !db.DisableNestedTransaction { | ||
| err = db.SavePoint(fmt.Sprintf("sp%p", fc)).Error | ||
| spID := new(maphash.Hash).Sum64() |
There was a problem hiding this comment.
instead of sprintf two times for the same id we could just do:
spID := fmt.Sprintf("sp%d", new(maphash.Hash).Sum64())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This test changes
SAVEPOINTnames from relying on the memory address of the callback (which can cause unexpected issues with partial rollbacks), to using a random integer.The integer is generated using
maphash.Hash, which is used as that internally relies onruntime.fastrand, which is the most performant way to get a random integer.I've ensured the test fails without my code changes, and passes with them applied.
Use Case Description
Covered in #7173