-
Notifications
You must be signed in to change notification settings - Fork 52
feat(tagged): add an option to query clickhouse for term weights in tagged queries #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mchrome
wants to merge
13
commits into
go-graphite:master
Choose a base branch
from
mchrome:feat/optimal-tag1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+623
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrMatsko
approved these changes
Mar 4, 2025
Tetrergeru
reviewed
Mar 17, 2025
Tetrergeru
approved these changes
Mar 17, 2025
I don't understand how tagged table works and which issue is solved here. Sorry, I can't provide the feedback =\ We need @msaf1980 here |
msaf1980
reviewed
Mar 31, 2025
…eriesByTag have not been found inside the count table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the config parameter
tag1-count-table = <table_name>
. If set, graphite-clickhouse will query this table, which helps to choose the best Tag1 value to use when queryinggraphite_tagged
table.A slightly more detailed description can be found in config.md changes.