Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated kitgen #1121

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Remove deprecated kitgen #1121

merged 1 commit into from
Jun 30, 2021

Conversation

sagikazarmark
Copy link
Contributor

Fixes #1116

@peterbourgon
Copy link
Member

Is kitgen referenced anywhere else?

@sagikazarmark
Copy link
Contributor Author

I looked for it in this repo, the website and issues/PRs. Couldn't find any. Might be worth to update the list in #843

@sagikazarmark sagikazarmark mentioned this pull request Jun 24, 2021
Closed
@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 27, 2021
peterbourgon
peterbourgon approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@peterbourgon peterbourgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no mentions in the README then 🚢 🇮🇹

@sagikazarmark
remove deprecated kitgen
32681cc 
Signed-off-by: Mark Sagi-Kazar <[email protected]>
@sagikazarmark sagikazarmark merged commit f80eb06 into go-kit:master Jun 30, 2021
@sagikazarmark sagikazarmark deleted the remove-kitgen branch June 30, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Extract kitgen to an external repository
2 participants
@sagikazarmark @peterbourgon