fix: sources brace expansion #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd93
force-pushed
the
2073-fix-sources-brace-expansion
branch
2 times, most recently
from
12df237 to
2a1e9da
Compare
pd93
force-pushed
the
2073-fix-sources-brace-expansion
branch
from
2a1e9da to
0c25845
Compare
pd93
force-pushed
the
2073-fix-sources-brace-expansion
branch
from
0c25845 to
f990a60
Compare
pd93
added a commit
that referenced
this pull request
Apr 19, 2025
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073
Removes
zglobas a dependency and instead relies on mvdan'sexpand.Fieldswith globbing turned on forsourcesglobs.We also use
expand.Fieldsin multiple other places to resolve things like~and environment variables. However, most of the time, we don't also want brace expansion or globbing, so I have separated this into two functions. One wrapsexpand.Literalwhich returns a single string with just the variables resolved, and the other wrapsexpand.Fieldswith braces and globbing enabled.