refactor: ast.Call should be in main task package #2084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calldoesn't belong in thetaskfile/astpackage. It's not a part of the Taskfile schema. It was previously used, but has since been refactored out. Since aCallis something that the tool does, I feel it should be a part of the maintaskpackage.In order to do this, there are a couple of other small refactors that need to be done so that we don't get circular dependency issues:
Compilerneeds moving into the main task package instead of being in its owninternalpackage. Historically,Compilerwas an interface with multiple implementations, but this is no longer the case, so I don't think there is a need for package anymore.FindMatchingTasksalso needs to be moved from thetaskfile/astpackage into the maintaskpackage, but this makes sense to me anyway. Thetaskfile/astpackage should be for the AST/paring code only, not for logic. I have moved this to a method on theExecutorfor now.