-
-
Notifications
You must be signed in to change notification settings - Fork 763
feat: support for loops with generates #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pd93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. If willing, could you please add this change to the schema reference and usage doc. We can probably combine the sections on looping over sources/generates rather than having separate ones.
a0acc1e to
2776bbf
Compare
vmaerten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good ! Can you update the schema.json in order to add this new property ?
It's under for_attribute
2776bbf to
3929428
Compare
Yeah, sure. I've updated the enum values. |
vmaerten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pd93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sedyh 🚀
|
FYI, made some changes to the docs in 669bf33. |
Hello. When I encountered that Task doesn't have fingerprinting for generated files, I started looking for workarounds by using
status: test -ffor each item in thegeneratedlist and suddenly realized that I can't just automate these type of checks because I can't loop overgenerated. The idea is to extend pr-1541: looping over dependencies with one more value.This PR is for:
generatesvalue withforincmdsanddeps.There will be a second PR for:
statusfor programmatic checks automation.My workaround for checking generated files, that I want to run with this PR:
Original problem with the missing checks for generated files: