refactor(fsnotifyext): remove unnecessary mutex usage from Deduper#2196
Merged
andreynering merged 6 commits intogo-task:mainfrom May 26, 2025
Merged
refactor(fsnotifyext): remove unnecessary mutex usage from Deduper#2196andreynering merged 6 commits intogo-task:mainfrom
andreynering merged 6 commits intogo-task:mainfrom
Conversation
8e8f35f to
478dd5e
Compare
As recommended by the Event.Op godoc. Op is a bitmask, and some systems may send multiple operations at once
478dd5e to
b5d406c
Compare
andreynering
approved these changes
May 26, 2025
Member
andreynering
left a comment
There was a problem hiding this comment.
Thank you @wazazaby!
I found https://github.com/helshabini/fsbroker recently, and may give it a try.
In the meantime, your changes make sense, so I'm just merging it 🙂
Contributor
Author
|
@andreynering thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a small refactor of the
Dedupercomponent, here's a list of the introduced changes :Dedupertimers map to goroutine, to avoid mutex usage as it's read from / written to from a single goroutine.Deduper.GetChannow returns a receive only channel, as only the internalfsnotify.Watcherinstance should be allowed to send events to it.fsnotify.Event.Hasto check against Chmod operations (as per recommended by thefsnotify.Event.Opgodoc).Executor.watchTasks- remove check against Chmod operations, it's already handled in theDeduper.GetChangoroutine.Deduper.GetChanmethod to explain that.go mod tidy.Following the contributing guidelines, I will squash the commits upon merging (if it ever happens ^^).
Thank you :)