Adjust when_changed to work with imported tasks. #2511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Nov 22, 2025
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
Awesome. Thank you very much @trulede!
andreynering
added a commit
that referenced
this pull request
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
when_changedbehaviour to work more effectively with imported tasks, with reasoning similar to that behind PR #1655. A task imported several times withwhen_changedprobably should only be run once per "variable set" regardless of how many times that task is imported (by other taskfiles).I'm not certain if this change is the correct behaviour, it could be that this use case also represents a new
runcondition.Fixes #2508