fix: missing helpers

[james-d-elliott]

No description provided.

[coderabbitai]

Walkthrough

This change introduces a new mediation constant, updates method and parameter names for clarity, and adds a utility type for credential descriptor conversion. Internal calls are adjusted to use the new constant, and naming consistency is improved in several functions without altering underlying logic or control flow.

Changes

File(s)	Change Summary
protocol/authenticator.go	Added MediationDefault constant to CredentialMediationRequirement type.
protocol/credential.go	Renamed parameter in ParseCredentialCreationResponse from response to request and updated internal references.
webauthn/credential.go	Introduced Credentials type alias and CredentialDescriptors() method for converting credential slices.
webauthn/registration.go	Updated internal calls to use MediationDefault; renamed parameter in FinishRegistration for clarity.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WebAuthn
    participant Protocol

    User->>WebAuthn: BeginRegistration(user)
    WebAuthn->>WebAuthn: BeginMediatedRegistration(user, protocol.MediationDefault)
    WebAuthn-->>User: CredentialCreation, SessionData

    User->>WebAuthn: FinishRegistration(user, session, request)
    WebAuthn->>Protocol: ParseCredentialCreationResponse(request)
    Protocol-->>WebAuthn: ParsedCredentialCreationData
    WebAuthn-->>User: Credential

Loading

Possibly related PRs

• feat(protocol): credential mediation #361: Adds a new MediationDefault constant to the same mediation requirement set, directly extending related constants.
• fix(protocol): conditional create fail #434: Modifies verification logic to conditionally check user presence based on mediation requirements, which the new constant supports.

Poem

A hop, a skip, a constant new,
Mediation flows now clearer too.
Credentials gathered in a bunch,
Their descriptors ready for a munch.
With names aligned and code refined,
This bunny hops ahead, streamlined! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 088d7c4 and 7e13dfc.

📒 Files selected for processing (4)

• protocol/authenticator.go (1 hunks)
• protocol/credential.go (1 hunks)
• webauthn/credential.go (1 hunks)
• webauthn/registration.go (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (3)

webauthn/credential.go (2)

protocol/credential.go (1)

• Credential (16-25)

protocol/options.go (1)

• CredentialDescriptor (62-74)

protocol/credential.go (1)

protocol/errors.go (1)

• ErrBadRequest (47-50)

webauthn/registration.go (3)

protocol/authenticator.go (1)

• MediationDefault (69-69)

webauthn/types.go (3)

• WebAuthn (24-26)
• User (173-201)
• SessionData (205-216)

protocol/credential.go (2)

• Credential (16-25)
• ParseCredentialCreationResponse (65-74)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (go)

🔇 Additional comments (5)

protocol/authenticator.go (1)

68-70: LGTM! Good addition of named constant.

The new MediationDefault constant improves code clarity by replacing magic string literals with a well-documented named constant. This follows the established pattern of other mediation requirement constants and makes the code more maintainable.

webauthn/credential.go (1)

38-51: LGTM! Useful utility type addition.

The new Credentials type and CredentialDescriptors() method provide a clean way to convert credential slices to descriptor slices. The implementation is efficient with proper slice preallocation and correctly iterates through the credentials.

protocol/credential.go (1)

65-73: LGTM! Parameter naming improvement.

The parameter rename from response to request correctly reflects that the function accepts an *http.Request. All internal references have been consistently updated, improving code clarity without changing functionality.

webauthn/registration.go (2)

24-24: LGTM! Improved consistency using named constant.

Using protocol.MediationDefault instead of an empty string literal improves code readability and maintainability. This change aligns with the constant addition in protocol/authenticator.go.

---

215-216: LGTM! Parameter naming consistency improvement.

The parameter rename from response to request maintains consistency with the corresponding change in protocol.ParseCredentialCreationResponse. The function call has been updated accordingly, preserving functionality while improving code clarity.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.