ignoring non-lock nodes when processing for lockWithData #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 76.11% 75.90% -0.22%
==========================================
Files 7 7
Lines 1189 1191 +2
==========================================
- Hits 905 904 -1
- Misses 195 196 +1
- Partials 89 91 +2
Continue to review full report at Codecov.
|
nemith
reviewed
Mar 26, 2021
| prevSeq := -1 | ||
| prevSeqPath := "" | ||
| for _, p := range children { | ||
| if !(strings.HasPrefix(p, protectedPrefix) || strings.Contains(strings.ToUpper(p), "__LOCK__")) { |
There was a problem hiding this comment.
I may be blind but where is protectedPrefix coming from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a problems when nodes at lock node level where protected Ephemeral nodes are created have user created nodes as well. lockWithData function tries to use those user created node to calculate sequence number and it fails or stuck .