Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrencyAlert v2.2.0.0 #4797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MidoriKami
Copy link
Contributor

API11

I expect no issues with this one.

@bleatbot bleatbot enabled auto-merge (squash) November 15, 2024 21:05
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 15, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 7 hours.

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 ⚠️ Upd. from 5ad86f9c8a6373f6b41dea915f0adce10373d05fUpd. from 5ad86f9c8a6373f6b41dea915f0adce10373d05f)
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 ⚠️ Upd. from 69f0b57e275c7a58e031569ddf502ec62e785ed2Upd. from 69f0b57e275c7a58e031569ddf502ec62e785ed2)
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 15, 2024
@MidoriKami
Copy link
Contributor Author

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 15, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 ⚠️ Upd. from 5ad86f9c8a6373f6b41dea915f0adce10373d05fUpd. from 5ad86f9c8a6373f6b41dea915f0adce10373d05f)
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 ⚠️ Upd. from 69f0b57e275c7a58e031569ddf502ec62e785ed2Upd. from 69f0b57e275c7a58e031569ddf502ec62e785ed2)
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

@MidoriKami
Copy link
Contributor Author

No idea why the build is failing, log suggests some kind of internal build error with packager.

@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 16, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 goaaats
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

@reiichi001
Copy link
Contributor

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 17, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 goaaats
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

@MidoriKami
Copy link
Contributor Author

It definitely builds locally for me, I genuinely don't know what the problem could be. NoTankYou seemed to report the same issue, seems like it failed to build once after it was merged, but then seemed to build fine afterwards.

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 17, 2024

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 goaaats
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

@goaaats
Copy link
Member

goaaats commented Nov 17, 2024

This must be an issue in DalamudPackager caused by the new SDK, in connection to libs. Not 100% sure how to solve it yet but I'll look at it tonight. We might have to have a permutation of Dalamud.NET.Sdk that doesn't include DalamudPackager.

@MidoriKami
Copy link
Contributor Author

I just don't know why it would work for my other plugins and not this one, I'm not aware of doing anything differently here.

@MidoriKami
Copy link
Contributor Author

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
CurrencyAlert [stable] b476962 Build failed (Diff)
15 Needs (✅ All reviewed)
Type Name Version Reviewed by
Submodule https://github.com/MidoriKami/KamiLib.git 427d7919b1f5a154daf6815216086604f804f1b5 goaaats
Submodule https://github.com/MidoriKami/KamiToolKit.git 8027b76b17f649ccd379e14598858d60dd6a9d42 goaaats
NuGet NetStone 1.1.1 reiichi001
NuGet HtmlAgilityPack 1.11.46 reiichi001
NuGet Karashiiro.HtmlAgilityPack.CssSelectors.NetCoreFork 0.0.2 reiichi001
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
9 hidden needs (known safe NuGet packages).
Show log - Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failed This plugin failed to build.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants