-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: update uptime-kuma skip path documentation #12641
Conversation
Modify the skip path regex to be more restrictive without modifying the intended functionality. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Added skip path regex rule for push based monitoring. - Modified a rule to be more descriptive. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
- Added skip path regex rule for badges. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @itskagee ! Nothing major, some questions and perhaps some needed clarification, but approving now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12641 +/- ##
==========================================
- Coverage 92.75% 92.75% -0.01%
==========================================
Files 769 769
Lines 38879 38879
==========================================
- Hits 36064 36063 -1
- Misses 2815 2816 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @itskagee the |
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
Apologies. I've updated the PR to add your suggestions and the linting changes! |
…uthentik#12641) * Update documentation for Uptime-Kuma integration Modify the skip path regex to be more restrictive without modifying the intended functionality. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com> * Update uptime-kuma integration docs - Added skip path regex rule for push based monitoring. - Modified a rule to be more descriptive. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com> * Update uptime kuma integration docs - Added skip path regex rule for badges. Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com> Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com> * website/docs: uptime kuma apply linting changes --------- Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com> Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Modify the skip path regex to be more restrictive without modifying the intended functionality.
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)