Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: update uptime-kuma skip path documentation #12641

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

itskagee
Copy link
Contributor

Modify the skip path regex to be more restrictive without modifying the intended functionality.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Sorry, something went wrong.

Modify the skip path regex to be more restrictive without modifying the intended functionality.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
@itskagee itskagee requested a review from a team as a code owner January 11, 2025 04:36
Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 17bcb4f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6786a9daf416390008407df4
😎 Deploy Preview https://deploy-preview-12641--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 17bcb4f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6786a9db54616000082d1130
😎 Deploy Preview https://deploy-preview-12641--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Added skip path regex rule for push based monitoring.
- Modified a rule to be more descriptive.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
- Added skip path regex rule for badges.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itskagee ! Nothing major, some questions and perhaps some needed clarification, but approving now.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (09931bc) to head (17bcb4f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12641      +/-   ##
==========================================
- Coverage   92.75%   92.75%   -0.01%     
==========================================
  Files         769      769              
  Lines       38879    38879              
==========================================
- Hits        36064    36063       -1     
- Misses       2815     2816       +1     
Flag Coverage Δ
e2e 48.58% <ø> (ø)
integration 24.63% <ø> (ø)
unit 90.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

Hi @itskagee the lint (prettier-check) build check is failing... can you run make website again loclaly to format it, then push to PR?

itskagee and others added 2 commits January 14, 2025 11:32
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
@itskagee
Copy link
Contributor Author

itskagee commented Jan 14, 2025

Apologies.
I thought a linting check might be unnecessary for such a small change, so I made the modifications from the github interface itself.
It was a wrong presumption from my end.

I've updated the PR to add your suggestions and the linting changes!

@tanberry tanberry merged commit 463efac into goauthentik:main Jan 15, 2025
65 of 67 checks passed
mahmoudajawad pushed a commit to mahmoudajawad/authentik that referenced this pull request Jan 15, 2025
…uthentik#12641)

* Update documentation for Uptime-Kuma integration

Modify the skip path regex to be more restrictive without modifying the intended functionality.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>

* Update uptime-kuma integration docs

- Added skip path regex rule for push based monitoring.
- Modified a rule to be more descriptive.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>

* Update uptime kuma integration docs

- Added skip path regex rule for badges.

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>

* website/docs: uptime kuma apply linting changes

---------

Signed-off-by: itskagee <17406594+itskagee@users.noreply.github.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
@itskagee itskagee deleted the patch-1 branch January 16, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants