Skip to content

Conversation

@Rsgm
Copy link
Contributor

@Rsgm Rsgm commented Apr 10, 2025

Details

Fixes the previously removed post body authentication scheme that breaks Apple authentication.
Apple expects client credentials in the token post body, instead of basic auth.
This attempts to maintain the fix in the previous PR while addressing the new issue affecting the Apple source.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@netlify
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8fc0860
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67f714cb809d4500083f9117

@netlify
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 8fc0860
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67f714cb7646fb00085b8e8b

@Rsgm Rsgm marked this pull request as ready for review April 10, 2025 00:23
@Rsgm Rsgm requested a review from a team as a code owner April 10, 2025 00:23
@Rsgm Rsgm marked this pull request as draft April 10, 2025 00:33
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (41dc23b) to head (8fc0860).
Report is 223 commits behind head on main.

Files with missing lines Patch % Lines
authentik/sources/oauth/clients/oauth2.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13958      +/-   ##
==========================================
- Coverage   92.78%   92.73%   -0.06%     
==========================================
  Files         796      796              
  Lines       40761    40767       +6     
==========================================
- Hits        37821    37804      -17     
- Misses       2940     2963      +23     
Flag Coverage Δ
e2e 47.79% <84.61%> (-0.08%) ⬇️
integration 24.17% <53.84%> (+<0.01%) ⬆️
unit 90.54% <53.84%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants