Monorepo Part 2: Putting it all together #14002

GirlBossRush · 2025-04-11T02:48:27Z

Details

This PR concludes the majority of #1368, allowing us to take advantage of NPMs workspaces, TypeScript's project-wide compiler, and our packaged linter configurations.

Overall, the changes in this PR should keep existing code behaviors as they were, sometimes at the expense of turning off ESLint's more aggressive "nightmare mode" rules. A follow up PR will address disabled rules and avoid intermixing too much linter noise.

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2025-04-11T02:48:45Z

❌ Deploy Preview for authentik-docs failed. Why did it fail? →

Name	Link
🔨 Latest commit	`a4f92f5`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/68004f5f30fe000008ebb22d

netlify · 2025-04-11T02:48:50Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`a4f92f5`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/68004f5fd49cb80008f56f8b
😎 Deploy Preview	https://deploy-preview-14002--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

GirlBossRush · 2025-04-11T02:49:55Z

.vscode/tasks.json

 {
    "version": "2.0.0",
    "tasks": [
        {


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T02:50:11Z

.vscode/settings.json

            "prefix": "#<num>",
            "url": "https://github.com/goauthentik/authentik/issues/<num>",
            "ignoreCase": false
        }


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T02:50:27Z

.editorconfig

 trim_trailing_whitespace = true
 insert_final_newline = true

 [*.html]


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T02:51:06Z

.prettierignore

@@ -0,0 +1,51 @@
+# Prettier Ignorefile


Migrated and deduped from individual packages

GirlBossRush · 2025-04-11T02:51:14Z

.vscode/extensions.json

        "ms-python.black-formatter",
        "ms-python.debugpy",
        "ms-python.python",
        "ms-python.vscode-pylance",


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T02:51:40Z

lifecycle/aws/package.json

@@ -1,16 +1,16 @@
 {


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T02:52:54Z

package.json

+        "packages/*"
+    ],
+    "prettier": "@goauthentik/prettier-config",
+    "packageManager": "[email protected]+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610"


Auto set by NPM when workspaces are defined. Running npm will continue to work as expected without introducing a dependency on Yarn.

codecov · 2025-04-11T02:54:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (c15c0cb) to head (a4f92f5).
Report is 24 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14002      +/-   ##
==========================================
- Coverage   92.74%   91.60%   -1.15%     
==========================================
  Files         799      799              
  Lines       41230    41230              
==========================================
- Hits        38240    37767     -473     
- Misses       2990     3463     +473

Flag	Coverage Δ
e2e	`?`
integration	`24.10% <ø> (ø)`
unit	`90.60% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GirlBossRush · 2025-04-11T02:55:58Z

tsconfig.json

+        "excludeDirectories": [
+            "**/.git", // Git
+            "**/.yarn", // Yarn
+            "**/.vscode", // VS Code
+            "**/.vscode-test-web", // VS Code Web Test
+            "**/dist", // Distributed build files
+            "**/out", // Output build files
+            "**/.drafts", // Drafts
+            "**/.github", // GitHub
+            "**/node_modules" // Node modules


Each additional excluded directory improves the performance of watcher mode type checking, allowing TypeScript to skip cruft within imported node modules.

GirlBossRush · 2025-04-11T02:58:43Z

web/src/elements/router/RouteMatch.ts

-export function updateURLParams(params: { [key: string]: unknown }, replace = true): void {
+export function updateURLParams(nextParams: { [key: string]: unknown }, replace = true): void {
    const currentParams = getURLParams();
-    for (const key in params) {


Linter detected use of for in loop.

GirlBossRush · 2025-04-11T03:00:07Z

web/src/elements/wizard/ActionWizardPage.ts

-        this.states = [];
-
-        this.host.actions.map((act, idx) => {
-            this.states.push({
-                action: act,
-                state: ActionState.pending,
-                idx: idx,
-            });
-        });
+        this.states = this.host.actions.map((act, idx) => ({
+            action: act,
+            state: ActionState.pending,
+            idx: idx,
+        }));


Fix for linter warning of Array.prototype.map as side-effects.

GirlBossRush · 2025-04-11T03:01:22Z

web/tests/specs/new-application-by-wizard.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-nocheck
 // ^^^^^^^^^^^ Because TSC cannot handle metaprogramming, and metaprogramming
 // via `defineProperties` is how we installed the OUID finders for the various


Followed up in #13745

GirlBossRush · 2025-04-11T03:06:15Z

web/tsconfig.json

+        // TODO: We should enable this when when we're ready to enforce it.
+        "noUncheckedIndexedAccess": false,


Eventually enforcing this is quite the journey but worth it.

GirlBossRush · 2025-04-11T03:07:00Z

website/package.json

@@ -1,8 +1,8 @@
 {


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:08Z

website/remark/preview-directive.ts

@@ -1,9 +1,8 @@
-import "mdast-util-to-hast";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:14Z

website/remark/support-directive.ts

@@ -1,10 +1,8 @@
-import "mdast-util-to-hast";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:24Z

website/remark/version-directive.ts

@@ -1,10 +1,9 @@
-import "mdast-util-to-hast";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:33Z

website/sidebars.js

@@ -1,5 +1,5 @@
-import { generateVersionDropdown } from "./src/utils.js";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:44Z

website/src/components/MultilineCodeblock/index.tsx

@@ -1,12 +1,6 @@
-import React, {


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:07:53Z

website/src/components/VersionBadge.tsx

        throw new Error(`Invalid semver version: ${semver}`);
    }

    const yearCutoff = new Date().getFullYear() - 2;


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:08:05Z

website/src/css/custom.css

    --ifm-badge-background-color: var(--ifm-color-warning-contrast-background);
    --ifm-badge-color: var(--ifm-color-warning-contrast-foreground);
    --ifm-badge-border-color: var(--ifm-color-warning-contrast-foreground);
 }


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:08:14Z

website/src/hooks/title.ts

 * - the markdown content does not already contain a top-level h1 heading
 *
 * @vendor docusaurus
 */


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:08:19Z

website/src/pages/index.tsx

@@ -1,5 +1,5 @@
-import React from "react";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:08:25Z

website/src/theme/DocItem/Content/index.tsx

 * This component is a swizzled version of the original DocItemContent component.
 *
 * Similar to Docusaurus' default `DocItemContent`, this component renders
 * the content of a documentation page. However, it also adds support for


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:08:39Z

website/src/theme/EditMetaRow/index.tsx

@@ -1,13 +1,12 @@
-import React, { type ReactNode } from "react";


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:09:06Z

website/src/utils.js

@@ -1,27 +1,36 @@
+const html = String.raw;


🧹 File diff only contains linter changes.

GirlBossRush · 2025-04-11T03:09:18Z

website/test/sidebarIntegrations.mjs

@@ -1,7 +1,8 @@
-import test from "node:test";


🧹 File diff only contains linter changes.

github-actions · 2025-04-12T03:20:36Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b46ba9862ad8405626d4f5e098b5c505a41974ac
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b46ba9862ad8405626d4f5e098b5c505a41974ac

Afterwards, run the upgrade commands from the latest release notes.

web: Update config. Flesh out build. Fix issue surrounding build. Fix paths. Update workspaces. Fix build steps. Apply linter. Temporarily remove problem rules. Add ignorefile. Prep for formatting. Lint website. Lint web, repo packages. Refine Prettier usage. Fix imports. Tidy build. Move node ignore files. Remove unused. Update job. Fix lint step. Build before compiling. Use root for paths. Fix issues surrounding import references, types, package names. Fix build paths. Tidy. Enforce prefix. Apply prefixes to imports. Enable linter, compiler, etc. Fix references. Update names. Mark optional. Revise mounts. Fix build order. Update package.json. Ignore all docusaurus. Fix paths, types. Clean up build steps, names. Fix paths. website: Fix nested paragraphs build warning. web: Enforce module resolution. Use consistent LTS version. Track Node version. Use default resolution. Test main entrypoint. Fix Node v20 compatibility. Add task names. WIP: Fix styles.

GirlBossRush self-assigned this Apr 11, 2025

GirlBossRush requested review from a team as code owners April 11, 2025 02:48

GirlBossRush commented Apr 11, 2025

View reviewed changes

.vscode/tasks.json

{

"version": "2.0.0",

"tasks": [

{

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 File diff only contains linter changes.

GirlBossRush commented Apr 11, 2025

View reviewed changes

.prettierignore

@@ -0,0 +1,51 @@

# Prettier Ignorefile

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrated and deduped from individual packages

GirlBossRush commented Apr 11, 2025

View reviewed changes

lifecycle/aws/package.json

@@ -1,16 +1,16 @@

{

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 File diff only contains linter changes.

GirlBossRush commented Apr 11, 2025

View reviewed changes

website/package.json

@@ -1,8 +1,8 @@

{

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 File diff only contains linter changes.

GirlBossRush commented Apr 11, 2025

View reviewed changes

website/src/pages/index.tsx

@@ -1,5 +1,5 @@

import React from "react";

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 File diff only contains linter changes.

GirlBossRush commented Apr 11, 2025

View reviewed changes

website/src/utils.js

@@ -1,27 +1,36 @@

const html = String.raw;

Copy link

Contributor Author

GirlBossRush Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 File diff only contains linter changes.

GirlBossRush commented Apr 11, 2025

View reviewed changes

GirlBossRush force-pushed the monorepo-v3 branch 3 times, most recently from 45926a6 to 4a62cbd Compare April 12, 2025 02:50

GirlBossRush force-pushed the monorepo-v3 branch 4 times, most recently from ca2e478 to b46ba98 Compare April 15, 2025 00:13

GirlBossRush mentioned this pull request Apr 16, 2025

core: Format templates. #14109

Open

6 tasks

GirlBossRush force-pushed the monorepo-v3 branch from b46ba98 to a4f92f5 Compare April 17, 2025 00:46

GirlBossRush closed this Apr 21, 2025

GirlBossRush mentioned this pull request Apr 21, 2025

web: Use monorepo package utilities to build packages #14159

Merged

6 tasks

		// TODO: We should enable this when when we're ready to enforce it.
		"noUncheckedIndexedAccess": false,

		@@ -1,5 +1,5 @@
		import { generateVersionDropdown } from "./src/utils.js";

		@@ -1,13 +1,12 @@
		import React, { type ReactNode } from "react";

Uh oh!

Monorepo Part 2: Putting it all together #14002

Monorepo Part 2: Putting it all together #14002

Uh oh!

Conversation

GirlBossRush commented Apr 11, 2025

Details

Checklist

Uh oh!

netlify bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for authentik-docs failed. Why did it fail? →

Uh oh!

netlify bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

netlify bot commented Apr 11, 2025 •

edited

Loading

netlify bot commented Apr 11, 2025 •

edited

Loading

codecov bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 12, 2025 •

edited

Loading