fix: improve prometheusrules (to show more labels and fix messages) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rissson
approved these changes
Nov 29, 2023
|
wow, this PR is approved for a year but not merged yet. |
|
It needs some conflicts fixing and a review from @BeryJu |
Signed-off-by: genofire <[email protected]>
…namespace and service)
BeryJu
approved these changes
Feb 13, 2025
wrenix
suggested changes
Feb 14, 2025
| @@ -161,7 +160,7 @@ spec: | |||
| - alert: DisconnectedOutposts | |||
| labels: | |||
| severity: critical | |||
| expr: max without (endpoint,instance,container,pod,job,service) (authentik_outposts_connected{uid!~"specific.*"}) < 1 | |||
| expr: max by (outpost) (authentik_outposts_connected{namespace="{{ $.Release.Namespace }}", service="{{ include "authentik.names.fullname" $ }}-metrics", uid!~"specific.*"}) < 1 | |||
There was a problem hiding this comment.
missing namespace and service to identify which helm-release alerts ...
| @@ -127,19 +127,18 @@ spec: | |||
| - alert: NoWorkersConnected | |||
| labels: | |||
| severity: critical | |||
| expr: max without (endpoint,instance,container,job,service) (authentik_admin_workers) < 1 | |||
| expr: max by (pod) (authentik_admin_workers{namespace="{{ $.Release.Namespace }}", service="{{ include "authentik.names.fullname" $ }}-metrics"}) < 1 | |||
There was a problem hiding this comment.
extract the filter to a helm-template variable and reuse it everywhere (instatt of code copy):
{{- $filter := printf 'namespace="%s", service="%s-metrics"' .Release.Namespace (include "authentik.names.fullname" . ) }}
expr: max by (pod) (authentik_admin_workers{ {{ $filter }} }) < 1
rissson
requested changes
Feb 14, 2025
| @@ -127,30 +127,29 @@ spec: | |||
| - alert: NoWorkersConnected | |||
| labels: | |||
| severity: critical | |||
| expr: max without (pid) (authentik_admin_workers) < 1 | |||
| expr: max by (pod) (authentik_admin_workers{namespace="{{ $.Release.Namespace }}", service="{{ include "authentik.names.fullname" $ }}-metrics"}) < 1 | |||
There was a problem hiding this comment.
The service is authentik-server-metrics, not just authentik-metrics, or {{ include "authentik.server.fullname" . }}-metrics
There was a problem hiding this comment.
maybe we should use service=~"^{{ include "authentik.server.fullname" . }}.*"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.