Add Kubernetes service connection as data source #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 78.92% 78.94% +0.01%
==========================================
Files 106 107 +1
Lines 12184 12238 +54
==========================================
+ Hits 9616 9661 +45
- Misses 2073 2079 +6
- Partials 495 498 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
larstobi
reviewed
Jun 15, 2025
larstobi
reviewed
Jun 15, 2025
larstobi
reviewed
Jun 15, 2025
larstobi
reviewed
Jun 15, 2025
|
I added some suggestions to tests to get the coverage above 80%. Hopefully this makes the PR able to be merged? |
BeryJu
approved these changes
Jun 15, 2025
|
|
||
| req := c.client.OutpostsApi.OutpostsServiceConnectionsKubernetesList(ctx) | ||
| if s, ok := d.GetOk("name"); ok { | ||
| req = req.Name(s.(string)) |
There was a problem hiding this comment.
can remove the if here since name is marked as required and set that on the request inline
Co-authored-by: Lars Tobias Skjong-Børsting <[email protected]> Signed-off-by: Jens L. <[email protected]>
BeryJu
force-pushed
the
feature/data-source-kubernetes-service-connection
branch
from
81d755a to
d373545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing this data source, since the authentik helm chart comes with a service connection out of the box.