Conversation
enzo-bitfly
left a comment
enzo-bitfly
left a comment
There was a problem hiding this comment.
great work, and also great that you updated the README!
| @@ -593,6 +596,7 @@ func main() { | |||
|
|
|||
| authRouter.HandleFunc("/subscriptions/data", handlers.UserSubscriptionsData).Methods("GET") | |||
| authRouter.HandleFunc("/generateKey", handlers.GenerateAPIKey).Methods("POST") | |||
There was a problem hiding this comment.
issue: we should probably remove everything related to the old API key generation (handlers, templates, and this route - also some DB calls) - maybe @LuccaBitfly can help.
Can be done after this PR.
go.mod
Outdated
| go.opentelemetry.io/otel/trace v1.31.0 // indirect | ||
| go.uber.org/multierr v1.11.0 // indirect | ||
| go.uber.org/zap v1.27.0 // indirect | ||
| golang.org/x/tools v0.29.0 // indirect |
There was a problem hiding this comment.
question: is it expected that all these modules are deleted?
templates/user/settings.html
Outdated
| {{ end }} | ||
| {{ end }} | ||
|
|
||
| <div class="alert alert-info alert-dismissible fade show my-3 p-3 d-flex " role="alert"> |
There was a problem hiding this comment.
issue: alert is meant for dynamic changes, and it shouldn't contain interactive elements. You could use role="region" (or use a <section> with a heading) to convey to assistive technologies that this message is important.
| } | ||
| </style> | ||
| {{ end }} | ||
| {{ define "user/api-key-management/create" }} |
There was a problem hiding this comment.
question: why is it necessary to define the whole path here?
static/api-key-management/list.ts
Outdated
|
|
||
| export function initApiKeysTable(api: ApiKeysClient, opts: InitOpts) { | ||
|
|
||
| const dt = $(opts.tableSelector).DataTable({ |
There was a problem hiding this comment.
style: let's try to stick to complete variable names at least for frontend code.
static/api-key-management/modal.ts
Outdated
| onHidden?: () => void; | ||
| }; | ||
|
|
||
| export function useBSModal(modalEl : HTMLElement, options: BSModalOptions = {}) { |
There was a problem hiding this comment.
issue: BS is a third party library. The idea is that we wrap it in our custom reusable logic (this function) and what we expose to our application doesn't mention that. So useModal should be a good name for this.
rucister
force-pushed
the
FE-150/api-key-management-section
branch
3 times, most recently
from
4753366 to
e27c82e
Compare
rucister
force-pushed
the
FE-150/api-key-management-section
branch
2 times, most recently
from
98289f0 to
10fc526
Compare
See: FE-153
rucister
force-pushed
the
FE-150/api-key-management-section
branch
3 times, most recently
from
0c83f54 to
0217e48
Compare
rucister
force-pushed
the
FE-150/api-key-management-section
branch
2 times, most recently
from
e359f97 to
037e84a
Compare
See: FE-150 See: FE-156 See: FE-165 See: FE-166 See: FE-167
rucister
force-pushed
the
FE-150/api-key-management-section
branch
from
037e84a to
1c26cee
Compare
enzo-bitfly
force-pushed
the
epic/api-v2
branch
from
d038359 to
770d106
Compare
2 participants
No description provided.