-
Notifications
You must be signed in to change notification settings - Fork 83
Output g2html directly #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sim642
wants to merge
82
commits into
master
Choose a base branch
from
g2html-ocaml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Output g2html directly #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rolls back to commit 760e44a8f8abe89031109cc5ee8506cafad8fff6.
tried new version, but seems like there is no option to disable the animation
Index (position()) based lookup breaks if XML doesn't contain analyses in same order for each global variable.
…r other analyses For #469.
Somehow broke now and filtered too much.
I've now added syntax highlighting with Pygments, so this now should be able to completely replace g2html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Refactoring, clean-up
performance
Analysis time, memory usage
setup
Dependencies, CI, releasing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the g2html output Goblint produces:
.dot
files for all function CFGs.Then g2html takes those and does the following:
.dot
files to get.svg
files.This PR shows that we can easily cut out the middle man and get rid of the Java-based g2html altogether by doing the following directly in Goblint:
.dot
files and also running Graphviz on them.The result is almost exactly the same HTML-like results viewing experience.
The only difference is that g2html includes a custom lexer for unpreprocessed C that's used for highlighting code in the g2html file view. This remake doesn't do highlighting, but I don't know if anyone even looks at the file view in g2html.
I think it's a minor loss for what otherwise allows us to get rid of an ancient Java-based component which just wastes time copying XML around and reconstructing liveness information.
Doing the same directly in OCaml means that this output is also available to Goblint installed via opam itself, where otherwise g2html isn't present.
TODO
Remove old single-XML output?Let's keep it for now as as possible fallback for when the new approach does fail.