Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llmsPostsSelect2 improvements #2806

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

llmsPostsSelect2 improvements #2806

wants to merge 3 commits into from

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Nov 14, 2024 •
edited
Loading

Description

Allowed llmsPostsSelect2 to be called on a group with different data-post-type and other attributes. Also adds data-placeholder support.

Fixes #2805

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg added this to the Next Available Release milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideadude ideadude Awaiting requested review from ideadude ideadude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: Awaiting Review
Milestone
Next Available Release
Development

Successfully merging this pull request may close these issues.
1 participant
@brianhogg