Fix leak #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Bbulatov wants to merge 2 commits into godbus:master from Bbulatov:fix_memory_leak

Bbulatov commented Jul 28, 2025


          Fix leak

b3706ab

kolyshkin reviewed

View reviewed changes

transport_nonce_tcp.go Outdated

Comment on lines 31 to 35

               	b, err := os.ReadFile(noncefile)
               	if err != nil {
+              		socket.Close()
               		return nil, err
               	}

Contributor

kolyshkin Jul 31, 2025

Probably makes sense to move os.ReadFile to before net.Dial, to simplify error cleanup.

Author

Bbulatov Aug 1, 2025

I agree with you, done


          fix_memory_leak_without_Close

fc5f2ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet