Rename libraries, and add more to example.gdextension.
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddy-exe
reviewed
Apr 11, 2025
Ivorforce
force-pushed
the
unified-names
branch
from
1ad3440 to
bd82d0f
Compare
paddy-exe
reviewed
Apr 11, 2025
…tomary on Windows. Drop `universal.` suffix on macOS, as this is implied if there is no distinction between arches. Add more targets for the .gdextension file, including web, more linux targets, and separate single and double builds.
Ivorforce
force-pushed
the
unified-names
branch
from
bd82d0f to
a009ff6
Compare
paddy-exe
approved these changes
Apr 11, 2025
Collaborator
paddy-exe
left a comment
paddy-exe
left a comment
There was a problem hiding this comment.
Looks good now. Thanks for taking in my feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Revival" of #55.
Now that
.frameworkis gone, renames are simpler (and relevant) again:libprefix, as this is not customary on Windows.libprefix was dropped with the latest PR.universal.suffix on macOS, as this is implied if there is no distinction between arches.This is pretty much the setup I use for NumDot right now.