Skip to content

GitHub Actions: Check URLs using lychee #10680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 12, 2025

This makes it possible to be aware of dead links and replace them with other resources (such as archived versions) as soon as possible.

Note that class reference URLs not checked within this repository, as I plan to also integrate lychee into godotengine/godot's CI (which has the source of the class reference files).

Note

CI will fail until we resolve #10674, so that we remove the download.tuxfamily.org links from the docs.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the idea. Shader function replacement links are correct.

Can't review the lychee action implementation

@skyace65
Copy link
Contributor

I rebased this PR since tetrapod's PR was merged and now the URL check is failing on a different link. I'm not sure why though because the link works for me.

This makes it possible to be aware of dead links and replace
them with other resources (such as archived versions) as
soon as possible.
@Calinou
Copy link
Member Author

Calinou commented Feb 17, 2025

I rebased this PR since tetrapod's PR was merged and now the URL check is failing on a different link. I'm not sure why though because the link works for me.

I've added gamedevartisan.com to exclusions. Some websites tend to block link checkers and will return various error codes (typically 429, but sometimes 403 or even 503 in this case).

@skyace65
Copy link
Contributor

@mhilbrunner I'd like your review before merging this since it's adding another check

@skyace65 skyace65 requested a review from mhilbrunner February 19, 2025 00:24
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like this is a good idea, and I didn't spot anything in the workflow. Looks good to me!

Some things can be expanded, but I think we want to see this in action first & iterate. So, lets go ahead.

@mhilbrunner mhilbrunner added the github_actions Pull requests that update GitHub Actions code label Feb 19, 2025
@mhilbrunner mhilbrunner merged commit e2c795c into godotengine:master Feb 19, 2025
2 checks passed
@mhilbrunner
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bisecting Regressions page out of date, including bad link
5 participants