-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
GitHub Actions: Check URLs using lychee #10680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the idea. Shader function replacement links are correct.
Can't review the lychee action implementation
c0c77ab
to
acbdf72
Compare
acbdf72
to
b1665b2
Compare
I rebased this PR since tetrapod's PR was merged and now the URL check is failing on a different link. I'm not sure why though because the link works for me. |
This makes it possible to be aware of dead links and replace them with other resources (such as archived versions) as soon as possible.
b1665b2
to
51a597f
Compare
I've added |
@mhilbrunner I'd like your review before merging this since it's adding another check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like this is a good idea, and I didn't spot anything in the workflow. Looks good to me!
Some things can be expanded, but I think we want to see this in action first & iterate. So, lets go ahead.
Thank you! |
This makes it possible to be aware of dead links and replace them with other resources (such as archived versions) as soon as possible.
Note that class reference URLs not checked within this repository, as I plan to also integrate lychee into godotengine/godot's CI (which has the source of the class reference files).
Note
CI will fail until we resolve #10674, so that we remove the
download.tuxfamily.org
links from the docs.