Skip to content

Replace axes colors in image #10770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025
Merged

Conversation

BLooperZ
Copy link
Contributor

This fixes #10765
The colors in the modified axes image now matches the colors in editor

Modification process:
I have swapped the green and blue color channels in the image
then optimized it using the same command from #5254

Thank you

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good but please convert this image to a webp file. You can find information on doing that in our documentation here: https://docs.godotengine.org/en/stable/contributing/documentation/docs_image_guidelines.html

@skyace65 skyace65 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:images Issues and PRs involving outdated or incorrect images in articles labels Mar 16, 2025
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only the axes colors don't match Godot, but also the orientation of the Z axis. The current image shows a left-handed coordinate system but Godot uses right-handed coordinate system. See: https://docs.godotengine.org/en/4.4/tutorials/3d/introduction_to_3d.html#coordinate-system.

Corrected:
yBTpgncaO
pmQJnqGdX2

And BTW the rotation direction indicators are easy to misinterpret (the solid/intersection part goes behind or in front of the given axis? 🤔 (answer: assuming X/Y rotation directions are shown correctly, the solid/intersection parts are behind the axes)). So would be nice if they could be improved. But that would be a bonus / shouldn't be necessary.

@BLooperZ BLooperZ requested review from skyace65 and kleonc March 28, 2025 12:37
@skyace65 skyace65 merged commit 848476d into godotengine:master Mar 30, 2025
2 checks passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:images Issues and PRs involving outdated or incorrect images in articles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swapped colors of y,z axes in docs figure
3 participants