Skip to content

Improve features carousel accessibility #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sameersharmadev
Copy link

@sameersharmadev sameersharmadev commented Jul 6, 2025

Fixes #1094

  • Added contrasting backgrounds to carousel arrows for better visibility
  • Improved credits text contrast
  • Added autoplay to showcase carousel with pause/resume button
  • Includes pagination dot indicators for better navigation

Production edit:

Enregistrement.d.ecran.le.2025-07-07.a.11.13.42.mov

@JohnVeness
Copy link
Collaborator

Thanks for doing this. It sounds good from the description. Can you supply any screenshots/video, or a demo site, of the changes?

Also, it might be better to not change formatting in files (e.g. adding new lines) in the same PR, to make your functional code changes easier to spot.

@sameersharmadev
Copy link
Author

@JohnVeness I tried deploying it for a demo site but I couldn't make it work, so here's a video. Let me know if you need anything else

features_accessiblity_fix.mp4

Also noted on the formatting, I’ll keep that in mind for future!

@JohnVeness
Copy link
Collaborator

Looks excellent :). The only thing I would like would be a rollover highlight effect for the arrows/circles, like you have already for the play/pause button.

@sameersharmadev
Copy link
Author

Thanks! I added the hover highlight effect on the arrows, matching the style of the play/pause button.
image
(left one is normal state, right one is hovered state, pause button is on hovered state too)
If you have any more feedback, just lmk

@JohnVeness
Copy link
Collaborator

Thanks, looks good to me. I'm not in charge here, though, so I'll let someone else review.

@sameersharmadev
Copy link
Author

Also, while working on this, I noticed that the carousel allows users to flip through the showcase images without waiting for the sliding animation to end. This causes some visual glitches when clicking rapidly.

This behavior already exists on the live site, and you can reproduce it by clicking the carousel arrows quickly. Since this wasn’t part of the original issue, I left it out for now, but I wanted to check: would you prefer I open a new issue for this, or fix it in this pr?

@JohnVeness
Copy link
Collaborator

Ah yes, I see the glitches you mention on the live site. I think it would be great to fix that in this PR - I don't think we insist on an issue for each PR, in this repo anyway.

@sameersharmadev
Copy link
Author

@JohnVeness fixed :D

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my comments at first glance. I assess the nature of the PR by itself, it's more something @coppolaemilio can do.

@adamscott adamscott requested a review from coppolaemilio July 7, 2025 15:16
@adamscott adamscott added enhancement topic:content Issues and PRs related to static content labels Jul 7, 2025
@sameersharmadev
Copy link
Author

I committed all the suggestions, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:content Issues and PRs related to static content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issue with the showcase images at top of features page
3 participants