-
-
Notifications
You must be signed in to change notification settings - Fork 22.9k
[macOS] Fix missing frame_changed signal to CameraFeed #104809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The |
When updating frames in camera feed, we always call one of |
8a7a2b8
to
1493082
Compare
Currently, the
|
25da7db
to
e276b5d
Compare
b1c7d7f
to
a152857
Compare
I think from a high level this makes sense. I don't really have the ability to test this. @stuartcarnie is this maybe something you can verify just to make sure? My only coding remark is that it's better to create a constant for the StringName itself, have a look at other places in the code where we do this. It's more efficient than constructing new StringNames all over. But that really is a nitpick. |
a152857
to
af78d59
Compare
@BastiaanOlij |
af78d59
to
8b4babd
Compare
8b4babd
to
ca2071d
Compare
fixed #104808
I will add the missing emit of the frame_changed signal in the CameraFeed class on macOS.