Fix exported variable type mismatch after script change #109405
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #68015
clip.2.mp4
Definitely not the best. This does have support for both C# and GDScript exported variables. I've done testing and it works for custom classes too. Inside
PlaceHolderScriptInstance::updatewe check if the value of the exported variable would be an object or not and then if the exported variable does have a value: we compare it with the new expected variables type and reset the value if not appropriate. There may still be some edge cases I haven't accounted for, but I wasn't able to find any during testing.I'm open for any constructive criticism or feedback. Thank you.