CI: Ensure draft PRs don't perform actions

[Repiteo]

Tweaks the runner conditional such that a drafted PR will not perform actions. While I don't think it can be completely exempted from attempting to start an action, this should ultimately aid in cleaning up the action queue

Gonna be converting this to/from a draft to verify that everything works as intended EDIT: Functionality verified! This not only prevents actions running on drafts, but it will stop a running action if converted to a draft & starts running actions when marked as ready for review!

[clayjohn]

A little bit of feature creep, but will drafting and undrafting force the actions to run again?

[AThousandShips]

This feels like pretty unexpected behavior to me, I would expect draft PRs to work just fine, draft status should IMO be about reviews not CI, to ensure things work and are ready for review

There's no substitute for being properly deliberate and intentional about your pushes, if anything it'd be nice to be able to handle too many rapid pushes in a row and delay running if a push happens within a certain window of a previous one, delaying for a bit after that to not start five CI runs that just run a few seconds into building all the platforms

I want my draft PRs to run CI and this would force me to make my PRs non-drafts to accomplish that properly (since not all CI features work correctly on forks at least the last time I checked), which would defeat the main goal namely not triggering requests for reviews

[Repiteo]

A little bit of feature creep, but will drafting and undrafting force the actions to run again?

Indeed it would! Similarly, an in-progress action would stop when becoming a draft

There's no substitute for being properly deliberate and intentional about your pushes, if anything it'd be nice to be able to handle too many rapid pushes in a row and delay running if a push happens within a certain window of a previous one, delaying for a bit after that to not start five CI runs that just run a few seconds into building all the platforms

Hmm, that'd definitely be a lot trickier. We can't exactly control user intent, and I don't know if there's metadata for determining a previous run.

I want my draft PRs to run CI and this would force me to make my PRs non-drafts to accomplish that properly (since not all CI features work correctly on forks at least the last time I checked), which would defeat the main goal namely not triggering requests for reviews

If there's CI inconsistencies with forks, that should absolutely be addressed. Do you have any specific examples in mind?

[AThousandShips]

At least a few months ago the static checks don't work correctly on forks, failing to find formatting and spelling errors, this has been the case for years as far as I recall

I've only seen a handful of people who don't expect CI to run on drafts, and the vast majority of inexperienced users don't use drafts, so this won't prevent running in the case of experienced users pushing ten times in an hour

I'd say if someone don't want CI to run they should use the proper tools for it instead, and we should document that better, rather than breaking expectations and hurting usability