feat(net/ghttp): add AutoDecodingBody configuration for ghttp.Server
#4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wln32
reviewed
Mar 13, 2025
| } | ||
| if body[0] == '<' && body[len(body)-1] == '>' { | ||
| r.bodyMap, _ = gxml.DecodeWithoutRoot(body) | ||
| } |
wln32
reviewed
Mar 13, 2025
| if len(body) > 5 && bytes.EqualFold(body[:5], xmlHeaderBytes) { | ||
| if gstr.Contains(contentType, "/xml") { | ||
| r.bodyMap, _ = gxml.DecodeWithoutRoot(body) | ||
| return |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an AutoDecodingBody configuration option to ghttp.Server and updates the request body parsing logic accordingly.
- Updated the ServerConfig structure to include AutoDecodingBody with a default value.
- Enhanced the parseBody function in ghttp_request_param.go to perform auto-decoding for JSON and XML based on the new configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| net/ghttp/ghttp_server_config.go | Added a new AutoDecodingBody field and updated its default value. |
| net/ghttp/ghttp_request_param.go | Modified body parsing to support auto-decoding based on the new configuration. |
| // XML format checks. | ||
| if len(body) > 5 && bytes.EqualFold(body[:5], xmlHeaderBytes) { | ||
| if gstr.Contains(contentType, "/xml") { | ||
| r.bodyMap, _ = gxml.DecodeWithoutRoot(body) |
There was a problem hiding this comment.
After decoding XML in the AutoDecodingBody block, consider adding a return statement to prevent falling through to the default decoding logic, which may inadvertently override the XML decoding result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.