Skip to content

Fixed a bug in the Oracle driver of the gf framework where lowercase table names were not supported. #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuyinw wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fixed a bug in the Oracle driver of the gf framework where lowercase table names were not supported. #4312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4fb2d5e
Fixed an issue where removing double quotes in the oracle driver's Do…
yuyinw Jun 14, 2025
08251bf
Remove spaces.
yuyinw Jun 14, 2025
d7ebdde
修改oracle驱动测试代码错误
yuyinw Jun 15, 2025
353eed2
修改oracle驱动测试代码中删除表接口未区分大小写
yuyinw Jun 15, 2025
044ab25
修改oracle驱动测试代码删除表接口支持大小写
yuyinw Jun 15, 2025
6956a29
Merge branch 'master' into gf_oracle
yuyinw Jun 19, 2025
9084c70
Fixed an issue where removing double quotes in the oracle driver's Do…
yuyinw Jun 14, 2025
699ed24
Remove spaces.
yuyinw Jun 14, 2025
5ff8d1e
修改oracle驱动测试代码错误
yuyinw Jun 15, 2025
e6f27c0
修改oracle驱动测试代码中删除表接口未区分大小写
yuyinw Jun 15, 2025
65834e4
修改oracle驱动测试代码删除表接口支持大小写
yuyinw Jun 15, 2025
229e633
add debug log
yuyinw Jun 19, 2025
f2d00cc
Merge remote-tracking branch 'origin/gf_oracle' into gf_oracle
yuyinw Jun 19, 2025
37c1378
mod oracle dropTable
yuyinw Jun 19, 2025
aefc0c0
mod oracle dropTable
yuyinw Jun 19, 2025
329dda4
Merge branch 'master' into gf_oracle
hailaz Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions contrib/drivers/oracle/oracle_do_filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ func (d *Driver) DoFilter(ctx context.Context, link gdb.Link, sql string, args [
if err != nil {
return
}
newSql, err = gregex.ReplaceString("\"", "", newSql)
if err != nil {
return
}
newSql, err = d.parseSql(newSql)
if err != nil {
return
Expand Down
15 changes: 2 additions & 13 deletions contrib/drivers/oracle/oracle_z_unit_init_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ package oracle_test
import (
"context"
"fmt"
"strings"

_ "github.com/sijms/go-ora/v2"

Expand Down Expand Up @@ -114,7 +113,7 @@ func createTable(table ...string) (name string) {
dropTable(name)

if _, err := db.Exec(ctx, fmt.Sprintf(`
CREATE TABLE %s (
CREATE TABLE "%s" (
ID NUMBER(10) NOT NULL,
PASSPORT VARCHAR(45) NOT NULL,
PASSWORD CHAR(32) NOT NULL,
Expand Down Expand Up @@ -152,15 +151,5 @@ func createInitTable(table ...string) (name string) {
}

func dropTable(table string) {
count, err := db.GetCount(ctx, "SELECT COUNT(*) FROM USER_TABLES WHERE TABLE_NAME = ?", strings.ToUpper(table))
if err != nil {
gtest.Fatal(err)
}

if count == 0 {
return
}
if _, err = db.Exec(ctx, fmt.Sprintf("DROP TABLE %s", table)); err != nil {
gtest.Fatal(err)
}
db.Exec(ctx, fmt.Sprintf(`DROP TABLE "%s"`, table))
}
Loading