Fix/issue 4231 bytea corruption #4532
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(contrib/drivers/pgsql): preserve bytea data containing 0x5D
Bug Description
Fixes issue #4231 where PostgreSQL
byteafields containing the byte0x5D(ASCII]) were being forcibly converted to0x7D(ASCII}), causing data corruption and image parsing failures.Root Cause
The ConvertValueForField function in contrib/drivers/pgsql/pgsql_convert.go was applying array syntax conversion (
[→{,]→}) to all slice types, including binary data intended forbyteafields. This conversion is only appropriate for PostgreSQL array types, not binary data.Changes Made
[]bytewithbyteafield type before applying array conversionbyteafields0x5DIntegration test (requires PostgreSQL)
cd contrib/drivers/pgsql
go test -v -run Test_Issue4231