-
Notifications
You must be signed in to change notification settings - Fork 90
Implement UserGroup Command in CLI #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mahbub570 <[email protected]>
@mahbub570 ldap has some features pending. |
Fix table alignment. |
Signed-off-by: mahbub570 <[email protected]>
Hi @mahbub570, are you still working this issue #164. If not, I’d like to explore it further to gain a better understanding of the project. |
Hi @bupd, What improvements are still needed for this PR? |
This PR is currently waiting for LDAP to get complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates user group management into the Harbor CLI by introducing commands and views for creating, updating, listing, retrieving, searching, and deleting user groups. Key changes include new API handler functions for user group operations, interactive CLI views using the BubbleTea framework for displaying results, and corresponding Cobra commands to expose the functionality.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pkg/views/usergroup/update/view.go | Implementation of interactive update form for user groups |
pkg/views/usergroup/search/view.go | New view to display search results for user groups |
pkg/views/usergroup/list/view.go | New view to list all user groups |
pkg/views/usergroup/get/view.go | View to display details of a specific user group |
pkg/api/usergroup_handler.go | API handlers for create, update, get, list, search, and delete operations |
cmd/harbor/root/usergroup/*.go | Cobra command implementations for user group operations |
cmd/harbor/root/cmd.go | Added registration of the user group command |
Comments suppressed due to low confidence (1)
cmd/harbor/root/usergroup/cmd.go:7
- [nitpick] Consider renaming the function 'Usergroup' to 'UserGroup' to maintain consistent capitalization with other parts of the codebase.
func Usergroup() *cobra.Command {
Hi @bupd what changes are required? |
Objective: Integrate user group management into the Harbor CLI, enabling admins to create, update, list, view, search, and delete user groups, along with managing their permissions.
Tasks:
CLI Commands for User Group Management:
Fixes: #164