Skip to content

Conversation

mahbub570
Copy link
Contributor

@mahbub570 mahbub570 commented Aug 14, 2024

Objective: Integrate user group management into the Harbor CLI, enabling admins to create, update, list, view, search, and delete user groups, along with managing their permissions.

Tasks:

CLI Commands for User Group Management:

  • Create: New user groups.
  • Update: Modify existing groups.
  • List: Show all groups.
  • Get: Retrieve specific group details.
  • Search: Find groups by criteria.
  • Delete: Remove groups.

Fixes: #164

@mahbub570
Copy link
Contributor Author

mahbub570 commented Aug 14, 2024

marge #116 Before it as LDAP is missing. @bupd Can you please give me suggestion ?

@mahbub570
Copy link
Contributor Author

Create:
create

Update:
update

List: .
image

Get:
image

Search:
search

Delete:
delete

@bupd
Copy link
Collaborator

bupd commented Aug 16, 2024

marge #116 Before it as LDAP is missing

@mahbub570 ldap has some features pending.

@bupd
Copy link
Collaborator

bupd commented Aug 16, 2024

Fix table alignment.

@bupd bupd added the help wanted Extra attention is needed label Dec 28, 2024
@Standing-Man
Copy link
Contributor

Hi @mahbub570, are you still working this issue #164. If not, I’d like to explore it further to gain a better understanding of the project.

@Standing-Man
Copy link
Contributor

Hi @bupd, What improvements are still needed for this PR?

@bupd
Copy link
Collaborator

bupd commented Feb 6, 2025

This PR is currently waiting for LDAP to get complete.

@Vad1mo Vad1mo requested a review from Copilot April 22, 2025 13:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates user group management into the Harbor CLI by introducing commands and views for creating, updating, listing, retrieving, searching, and deleting user groups. Key changes include new API handler functions for user group operations, interactive CLI views using the BubbleTea framework for displaying results, and corresponding Cobra commands to expose the functionality.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/views/usergroup/update/view.go Implementation of interactive update form for user groups
pkg/views/usergroup/search/view.go New view to display search results for user groups
pkg/views/usergroup/list/view.go New view to list all user groups
pkg/views/usergroup/get/view.go View to display details of a specific user group
pkg/api/usergroup_handler.go API handlers for create, update, get, list, search, and delete operations
cmd/harbor/root/usergroup/*.go Cobra command implementations for user group operations
cmd/harbor/root/cmd.go Added registration of the user group command
Comments suppressed due to low confidence (1)

cmd/harbor/root/usergroup/cmd.go:7

  • [nitpick] Consider renaming the function 'Usergroup' to 'UserGroup' to maintain consistent capitalization with other parts of the codebase.
func Usergroup() *cobra.Command {

@bupd bupd added the Changes Requesed feedback that must be addressed before merging. label Aug 12, 2025
@PrathamX595
Copy link
Contributor

Hi @bupd what changes are required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requesed feedback that must be addressed before merging. help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Usergroup Command

4 participants