enhancing artifact view command #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrathamX595
force-pushed
the
feat/enhancing_artifact_view
branch
7 times, most recently
from
3de8322 to
33b7d2e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 10.99% 10.88% -0.11%
==========================================
Files 173 173
Lines 8671 8752 +81
==========================================
Hits 953 953
- Misses 7612 7693 +81
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PrathamX595
force-pushed
the
feat/enhancing_artifact_view
branch
from
33b7d2e to
a8ac938
Compare
bupd
requested changes
Jun 3, 2025
There was a problem hiding this comment.
@PrathamX595 Thanks for your contribution
I would suggest adding it inside table instead of just printing in stdout. also make sure the output is consumable in both json and yaml formats.
Thanks
|
@bupd Sure I'll do the changes 👍 |
|
@bupd I can't find a visually appealing way to put all of the data into tables also considering different artifacts have different data is there some other way we should explore this ? |
Signed-off-by: PrathamX595 <[email protected]>
PrathamX595
force-pushed
the
feat/enhancing_artifact_view
branch
from
4c36383 to
4c2b519
Compare
bupd
requested changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #463
Currently the artifact list and artifact view commands have pretty much the same functionality, with this PR the artifact view command has more detailed information for an artifact
in this implementation additional information is added below the existing table (awaiting feedback for this one) #463 (comment)