Support multiple hosts for core

[Jamess11]

Added support for multiple core hosts at the ingress level.
In an air-gapped environment, we needed to add another ingress manually in order to make global docker registries such as docker.io and ghcr.io urls accessible via the habror we deloyed. With this change, it would be much more easy to manage.

[Vad1mo]

this won't work as harbor only supports one domain defined in external_url, everything else is redirected to to external_url

[Jamess11]

It works in our company, we cloned the ingress that was created by the helm chart to expose docker.io, ghcr.io and gcr.io, while the external url is set to harbor.io.
Harbor does depend on the external url to be available. It uses the external url in the suggested push and pull commands, and it makes the docker client use it during "docker pull".
So as long as the external url endpoint is available - it works flawlessly for us.

[Vad1mo]

I wasn't precise in my statement: it won't work across different networks. Where for example the external_url is in the public internet and the second domain is on the intranet. the clients on the intranet don't have access to the internet.

I guess this isn't the case for you.

[reasonerjt]

we needed to add another ingress manually in order to make global docker registries such as docker.io and ghcr.io urls accessible via the habror we deployed.

I don't understand why Harbor can host images in ghcr.io. Did you replicated the images? But how about the upstream images changes?

I'm afraid this change is too specific to your environment and not generic enough to justify merging it.

[bupd]

Thanks for the contribution.

I believe this might create the impression of full multi-host support in Harbor, which could be misleading.

[bupd]

Harbor doesn't truly support multi-host setups, as noted in goharbor/harbor#8243. Allowing multiple hostnames in the Helm chart adds confusion. it only enables redirection to the externalURL.

In practice, all traffic is handled by the primary host, making the other hostnames effectively cosmetic.

For true multi-host support, each hostname should be capable of directly handling requests, not redirecting to a single primary. Hope this make sense.

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.