Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable look and feel for portal #20848

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

baldarn
Copy link

@baldarn baldarn commented Aug 13, 2024

Comprehensive Summary of your change

This PR aims to let a user configure the look and feel from the harbor.yml file

Issue being fixed

Fixes #20847

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@baldarn baldarn requested a review from a team as a code owner August 13, 2024 11:23
@baldarn baldarn closed this Aug 13, 2024
@baldarn baldarn reopened this Aug 13, 2024
@baldarn baldarn changed the title Customizable portal setting.json with install script customizable look and feel for portal Aug 13, 2024
@baldarn baldarn force-pushed the main branch 2 times, most recently from 6adcfc0 to 691109c Compare August 13, 2024 13:37
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.24%. Comparing base (c8c11b4) to head (ef754ff).
Report is 259 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20848      +/-   ##
==========================================
+ Coverage   45.36%   46.24%   +0.87%     
==========================================
  Files         244      247       +3     
  Lines       13333    13779     +446     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6372     +323     
- Misses       6983     7075      +92     
- Partials      301      332      +31     
Flag Coverage Δ
unittests 46.24% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@baldarn
Copy link
Author

baldarn commented Aug 19, 2024

hi, any updates @OrlinVasilev ? is this pointing in a good direction?

@OrlinVasilev
Copy link
Member

@Vad1mo @wy65701436 can you check please

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand the code correctly?
This change does only kicks in on the installer and copies the look_and_feel tree in config.json.

@baldarn
Copy link
Author

baldarn commented Aug 23, 2024

Do I understand the code correctly? This change does only kicks in on the installer and copies the look_and_feel tree in config.json.

yep, this also allows you to bind images to the portal docker container.

@baldarn baldarn force-pushed the main branch 3 times, most recently from 85d54fd to 882ed25 Compare August 23, 2024 14:12
Signed-off-by: lorenzo farnararo <[email protected]>
make/photon/prepare/utils/configs.py Outdated Show resolved Hide resolved
make/photon/prepare/utils/portal.py Outdated Show resolved Hide resolved
Co-authored-by: Jose D. Gomez R. <[email protected]>
Signed-off-by: baldarn <[email protected]>
@baldarn
Copy link
Author

baldarn commented Aug 23, 2024

❤️ @josegomezr

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@OrlinVasilev
Copy link
Member

@baldarn are you still up for this?

@baldarn
Copy link
Author

baldarn commented Oct 24, 2024

@OrlinVasilev yea, to go on I would like to have a review. I'm really not into this logic. is this something that have sense? XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add customizable look and feel for portal
9 participants