-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customizable look and feel for portal #20848
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: lorenzo farnararo <[email protected]>
6adcfc0
to
691109c
Compare
Signed-off-by: lorenzo farnararo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20848 +/- ##
==========================================
+ Coverage 45.36% 46.24% +0.87%
==========================================
Files 244 247 +3
Lines 13333 13779 +446
Branches 2719 2845 +126
==========================================
+ Hits 6049 6372 +323
- Misses 6983 7075 +92
- Partials 301 332 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
hi, any updates @OrlinVasilev ? is this pointing in a good direction? |
@Vad1mo @wy65701436 can you check please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand the code correctly?
This change does only kicks in on the installer and copies the look_and_feel tree in config.json.
yep, this also allows you to bind images to the |
85d54fd
to
882ed25
Compare
Signed-off-by: lorenzo farnararo <[email protected]>
Co-authored-by: Jose D. Gomez R. <[email protected]> Signed-off-by: baldarn <[email protected]>
❤️ @josegomezr |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@baldarn are you still up for this? |
@OrlinVasilev yea, to go on I would like to have a review. I'm really not into this logic. is this something that have sense? XD |
Comprehensive Summary of your change
This PR aims to let a user configure the
look and feel
from theharbor.yml
fileIssue being fixed
Fixes #20847
Please indicate you've done the following: