Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Update the testcase for v2.12.0, changes include #21114

Open
wants to merge 1 commit into
base: release-2.12.0
Choose a base branch
from

Conversation

stonezdj
Copy link
Contributor

pull image from registry.goharbor.io instead of dockerhub
Update testcase to support Docker Image Can Be Pulled With Credential
Change gitlab project name when user changed.
Update permissions count and permission count total
Change webhook_endpoint_ui

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 30, 2024 05:59
@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Oct 30, 2024
@stonezdj stonezdj changed the title Update the testcase for v2.12.0, changes include [cherry-pick] Update the testcase for v2.12.0, changes include Oct 30, 2024
 pull image from registry.goharbor.io instead of dockerhub
 Update testcase to support Docker Image Can Be Pulled With Credential
 Change gitlab project name when user changed.
 Update permissions count and permission count total
 Change webhook_endpoint_ui

Signed-off-by: stonezdj <[email protected]>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@cfe421e). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21114   +/-   ##
=================================================
  Coverage                  ?   66.07%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114649           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75758           
  Misses                    ?    34750           
  Partials                  ?     4141           
Flag Coverage Δ
unittests 66.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants