Skip to content

Conversation

goshlanguage
Copy link

@goshlanguage goshlanguage commented Sep 12, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Allows ecr-public to be mirrored in the same way ecr-fips can be today

Issue being fixed

Fixes #(issue)
#22346

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@goshlanguage goshlanguage requested a review from a team as a code owner September 12, 2025 15:40
@goshlanguage goshlanguage force-pushed the update-ecr-regex-to-allow-public-mirror branch from 27c8688 to 9800b7a Compare September 12, 2025 16:16
@chlins
Copy link
Member

chlins commented Sep 15, 2025

@vincentni Please help to take a look for this change, thanks!

@chlins chlins added area/replication replication/adapters related to replication adapters labels Sep 15, 2025
@goshlanguage goshlanguage force-pushed the update-ecr-regex-to-allow-public-mirror branch from b9714f5 to f0b8e52 Compare September 16, 2025 18:59
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.88%. Comparing base (c8c11b4) to head (f0b8e52).
⚠️ Report is 568 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22351       +/-   ##
===========================================
+ Coverage   45.36%   65.88%   +20.51%     
===========================================
  Files         244     1072      +828     
  Lines       13333   115932   +102599     
  Branches     2719     2927      +208     
===========================================
+ Hits         6049    76386    +70337     
- Misses       6983    35310    +28327     
- Partials      301     4236     +3935     
Flag Coverage Δ
unittests 65.88% <ø> (+20.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pkg/reg/adapter/awsecr/adapter.go 68.62% <ø> (ø)

... and 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ored similar to how ecr-fips is

Signed-off-by: Ryan Hartje <[email protected]>
@goshlanguage goshlanguage force-pushed the update-ecr-regex-to-allow-public-mirror branch from f0b8e52 to f602314 Compare September 19, 2025 14:43
@goshlanguage
Copy link
Author

@chlins I don't mean to nag, but is it possible we won't get a review from @vincentni? Their github history looks a little sparse, and its been a few weeks.

If there are other tests I can add to raise confidence here, I'm happy to do so. Please let me know.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/replication replication/adapters related to replication adapters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants