Skip to content

Conversation

BojanZelic
Copy link

@BojanZelic BojanZelic commented Sep 29, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Does 2 things:

  • when creating a artifact through the pull through cache, because all creations are the result of pulls, sets the last pull time automatically
  • if a child artifact is pulled, then updates the parent and also sets the last_pull time to be the same as what it was set to on the child.

Issue being fixed

Fixes #22390

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@BojanZelic BojanZelic requested a review from a team as a code owner September 29, 2025 21:05
@BojanZelic BojanZelic force-pushed the fix-parent-child-last-pulled-timestamp branch from 9e2d560 to a6f2fe8 Compare September 29, 2025 21:07
}
}

func (suite *ArtifactHandlerTestSuite) TestUpdateParentArtifactPullTime() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to run this specific test due to some dependencies on postgres, so not 100% sure if this test will pass.

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.67%. Comparing base (c8c11b4) to head (a6f2fe8).
⚠️ Report is 572 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #22402      +/-   ##
==========================================
+ Coverage   45.36%   46.67%   +1.30%     
==========================================
  Files         244      252       +8     
  Lines       13333    14255     +922     
  Branches     2719     2927     +208     
==========================================
+ Hits         6049     6653     +604     
- Misses       6983     7246     +263     
- Partials      301      356      +55     
Flag Coverage Δ
unittests 46.67% <ø> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retention policy incorrectly deletes recently-pulled child manifests when parent manifest expires

4 participants