Skip to content

Conversation

deamen
Copy link

@deamen deamen commented Oct 11, 2025

Comprehensive Summary of your change

This PR add support for deploying harbor with podman, podman-docker and podman-compose on rhel/centos/rockylinux/almalinux/fedora.

Added --with-podman install option:

  1. The docker/docker-compose checks have been extended to support podman and podman compose
  2. The logging driver is set to json-file, configurations are read from harbor.yml, so the log location/names/rotation is the same as using docker
  3. The log container is removed from the rendered docker-compose.yml as podman does not support it
  4. The tests/ci/podman_install.sh is created for testing on redhat distro

Issue being fixed

Fixes #15105

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@deamen deamen requested a review from a team as a code owner October 11, 2025 07:56
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.86%. Comparing base (c8c11b4) to head (151c0d4).
⚠️ Report is 574 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22451       +/-   ##
===========================================
+ Coverage   45.36%   65.86%   +20.49%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116036   +102703     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76427    +70378     
- Misses       6983    35368    +28385     
- Partials      301     4241     +3940     
Flag Coverage Δ
unittests 65.86% <ø> (+20.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


usage=$'Please set hostname and other necessary attributes in harbor.yml first. DO NOT use localhost or 127.0.0.1 for hostname, because Harbor needs to be accessed by external clients.
Please set --with-trivy if needs enable Trivy in Harbor.
Please set --with-podman if you want to force prepare to treat the Docker CLI as Podman.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right pattern, b/c with the param like "--with-xxx", the "xxx" is always a component in Harbor. Like "--with-trivy"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure about this one when I started the PR. What should we use here? Will --podman be fine?

@@ -0,0 +1,122 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really triggered in CI when you add this script?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not triggered by CI yet, this is something I need guidance.
I tried to write a CI test with the ubuntu-latest runner but the podman version in ubuntu seems to be too old, it won't start up the containers.

This podman_install.sh will only work on RHEL/centos/rocky/almalinux/fedora, if we want to have CI test for deploying harbor with podman and podman-compose, we will need a red hat runner, or wait for Ubuntu 25.04.

Which direction should we go?

@stonezdj stonezdj requested review from a team and MinerYang October 13, 2025 09:17
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this from being accidentally merged. Because there are some disagreement, and this has to be verified in CI.

We also need to take a closer look, please give us a bit more time.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Podman

5 participants