-
Notifications
You must be signed in to change notification settings - Fork 5k
Deploy with podman and podman-compose #22451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Song Tang <[email protected]>
1dd7586
to
151c0d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22451 +/- ##
===========================================
+ Coverage 45.36% 65.86% +20.49%
===========================================
Files 244 1073 +829
Lines 13333 116036 +102703
Branches 2719 2931 +212
===========================================
+ Hits 6049 76427 +70378
- Misses 6983 35368 +28385
- Partials 301 4241 +3940
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
||
usage=$'Please set hostname and other necessary attributes in harbor.yml first. DO NOT use localhost or 127.0.0.1 for hostname, because Harbor needs to be accessed by external clients. | ||
Please set --with-trivy if needs enable Trivy in Harbor. | ||
Please set --with-podman if you want to force prepare to treat the Docker CLI as Podman. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right pattern, b/c with the param like "--with-xxx", the "xxx" is always a component in Harbor. Like "--with-trivy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure about this one when I started the PR. What should we use here? Will --podman
be fine?
@@ -0,0 +1,122 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really triggered in CI when you add this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not triggered by CI yet, this is something I need guidance.
I tried to write a CI test with the ubuntu-latest runner but the podman version in ubuntu seems to be too old, it won't start up the containers.
This podman_install.sh will only work on RHEL/centos/rocky/almalinux/fedora, if we want to have CI test for deploying harbor with podman and podman-compose, we will need a red hat runner, or wait for Ubuntu 25.04.
Which direction should we go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this from being accidentally merged. Because there are some disagreement, and this has to be verified in CI.
We also need to take a closer look, please give us a bit more time.
Thanks!
Comprehensive Summary of your change
This PR add support for deploying harbor with podman, podman-docker and podman-compose on rhel/centos/rockylinux/almalinux/fedora.
Added
--with-podman
install option:json-file
, configurations are read from harbor.yml, so the log location/names/rotation is the same as using dockerdocker-compose.yml
as podman does not support ittests/ci/podman_install.sh
is created for testing on redhat distroIssue being fixed
Fixes #15105
Please indicate you've done the following: