Skip to content

Conversation

PeterDaveHello
Copy link
Contributor

PR summary from GitHub Copilot:

This pull request updates the Traditional Chinese localization for the proxy cache connection limit settings, improving clarity and accuracy of the translated terms and descriptions.

Localization improvements for proxy cache settings:

  • Reworded CONNECTION_LIMIT to more accurately describe the "maximum connections to upstream registry" in Traditional Chinese.
  • Updated PROXY_CACHE_MAX_UPSTREAM_CONN_TIP and PROXY_CACHE_MAX_UPSTREAM_CONN_INPUT_TIP to provide clearer instructions and explanations for users configuring connection limits.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@PeterDaveHello PeterDaveHello requested a review from a team as a code owner October 16, 2025 19:29
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (5142380).
⚠️ Report is 577 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22468       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116105   +102772     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76448    +70399     
- Misses       6983    35421    +28438     
- Partials      301     4236     +3935     
Flag Coverage Δ
unittests 65.84% <ø> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 987 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chlins chlins added the release-note/update Update or Fix label Oct 17, 2025
@chlins chlins enabled auto-merge (squash) October 17, 2025 02:07
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@wy65701436 wy65701436 added the area/i18n Related to Translation changes. label Oct 17, 2025
@chlins chlins merged commit 4d3c023 into goharbor:main Oct 17, 2025
12 checks passed
@muham18
Copy link

muham18 commented Oct 17, 2025

Igtm

@PeterDaveHello PeterDaveHello deleted the Update_zh-tw branch October 17, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n Related to Translation changes. release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants