-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #383: Ability to authentificate to harbor using Bearer Token #384
Conversation
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.4.0 to 5.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/goreleaser/goreleaser-action/releases">goreleaser/goreleaser-action's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>What's Changed</h2> <ul> <li>feat: node 20 as default runtime (requires <a href="https://github.com/actions/runner/releases/tag/v2.308.0">Actions Runner v2.308.0</a> or later) by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/goreleaser/goreleaser-action/pull/432">goreleaser/goreleaser-action#432</a></li> <li>chore(deps): bump <code>@actions/core</code> from 1.10.0 to 1.10.1 in <a href="https://redirect.github.com/goreleaser/goreleaser-action/pull/434">goreleaser/goreleaser-action#434</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/goreleaser/goreleaser-action/compare/v4.6.0...v5.0.0">https://github.com/goreleaser/goreleaser-action/compare/v4.6.0...v5.0.0</a></p> <h2>v4.6.0</h2> <p>Reverts the change to <code>node20</code> runtime.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/goreleaser/goreleaser-action/compare/v4.5.0...v4.6.0">https://github.com/goreleaser/goreleaser-action/compare/v4.5.0...v4.6.0</a></p> <h2>v4.5.0</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/goreleaser/goreleaser-action/pull/427">goreleaser/goreleaser-action#427</a></li> <li>feat: bump to use node20 runtime, actions/checkout to v4 by <a href="https://github.com/kbdharun"><code>@kbdharun</code></a> in <a href="https://redirect.github.com/goreleaser/goreleaser-action/pull/430">goreleaser/goreleaser-action#430</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/kbdharun"><code>@kbdharun</code></a> made their first contribution in <a href="https://redirect.github.com/goreleaser/goreleaser-action/pull/430">goreleaser/goreleaser-action#430</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/goreleaser/goreleaser-action/compare/v4.4.0...v4.5.0">https://github.com/goreleaser/goreleaser-action/compare/v4.4.0...v4.5.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8"><code>7ec5c2b</code></a> chore(deps): bump <code>@actions/core</code> from 1.10.0 to 1.10.1 (<a href="https://redirect.github.com/goreleaser/goreleaser-action/issues/434">#434</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/3529a650d2cb08134fe7707d27dc62a0c93bec6e"><code>3529a65</code></a> chore: node 20 as default runtime (<a href="https://redirect.github.com/goreleaser/goreleaser-action/issues/432">#432</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/d2f6e33a35c9b611d80d6facefe33e5d2fe8f2db"><code>d2f6e33</code></a> chore(deps): bump crazy-max/ghaction-import-gpg from 5 to 6 (<a href="https://redirect.github.com/goreleaser/goreleaser-action/issues/433">#433</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/5fdedb94abba051217030cc86d4523cf3f02243d"><code>5fdedb9</code></a> revert: node20 change</li> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/81d9ad71850a31bc2c99f6355208b6442d0a5783"><code>81d9ad7</code></a> feat: bump to use node20 runtime, actions/checkout to v4 (<a href="https://redirect.github.com/goreleaser/goreleaser-action/issues/430">#430</a>)</li> <li><a href="https://github.com/goreleaser/goreleaser-action/commit/a10d0e32dce991f86e53faa7b4f269dedb82632f"><code>a10d0e3</code></a> chore(deps): bump word-wrap from 1.2.3 to 1.2.5 (<a href="https://redirect.github.com/goreleaser/goreleaser-action/issues/427">#427</a>)</li> <li>See full diff in <a href="https://github.com/goreleaser/goreleaser-action/compare/v4.4.0...v5.0.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=goreleaser/goreleaser-action&package-manager=github_actions&previous-version=4.4.0&new-version=5.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) Signed-off-by: ilyesAj <[email protected]> --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: ilyesAj <[email protected]>
0bd7900
to
7119205
Compare
53e165b
to
0bd7900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, thank you
can you update the documentation ?
insecure bool | ||
httpClient *http.Client | ||
bearerToken string | ||
ClientId string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that the ClientId
is not used
"bearer_token": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
DefaultFunc: schema.EnvDefaultFunc("BEARER_TOKEN", ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefaultFunc: schema.EnvDefaultFunc("BEARER_TOKEN", ""), | |
DefaultFunc: schema.EnvDefaultFunc("HARBOR_BEARER_TOKEN", ""), |
fixes goharbor#383 this is largely a copy/paste of goharbor#384 by @ilyesAj with the changes requested by @flbla
fixes goharbor#383 this is largely a copy/paste of goharbor#384 by @ilyesAj with the changes requested by @flbla Signed-off-by: robert lestak <[email protected]>
fixes #383 this is largely a copy/paste of #384 by @ilyesAj with the changes requested by @flbla --------- Signed-off-by: robert lestak <[email protected]> Signed-off-by: flbla <[email protected]> Co-authored-by: flbla <[email protected]>
see #409 |
related to: #383